fix: harden php prototype pollution sinks#597
Merged
Conversation
This was referenced Mar 28, 2026
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
php/var/unserializeagainst__proto__/constructor/prototypekey injectionphp/strings/parse_strby skipping dangerous key paths at assignment time instead of relying on regex-prototype guardsContext
This is the code-level follow-up for the remaining prototype-pollution security triage cluster:
Validation
corepack yarn exec vitest run test/custom/parse_str-prototype-pollution.vitest.ts test/custom/unserialize-prototype-pollution.vitest.tscorepack yarn exec vitest run test/generated/php/strings/parse_str.vitest.ts test/generated/php/var/unserialize.vitest.tstsxrepro scripts for bothparse_strandunserializegit diff --checkcorepack yarn checkreached the usual silent tail after all visible subchecks were greenNotes
parse_strandunserializeare currently not in the executable parity target set, sotest:parityreports them as unverified rather than runnable parity cases.council-reviewwas started and did not produce a concrete finding before entering its usual long multi-agent tail, so I did not block the PR on that tooling latency.