[aggregate] properly populate PrintSpec in cmd_aggregate#69
Merged
okayzed merged 2 commits intologv:masterfrom Jun 11, 2018
Merged
[aggregate] properly populate PrintSpec in cmd_aggregate#69okayzed merged 2 commits intologv:masterfrom
okayzed merged 2 commits intologv:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 52.16% 52.16%
=======================================
Files 36 36
Lines 3715 3715
=======================================
Hits 1938 1938
Misses 1580 1580
Partials 197 197Continue to review full report at Codecov.
|
this should be written in go but for now..
okayzed
approved these changes
Jun 11, 2018
Collaborator
okayzed
left a comment
okayzed
left a comment
There was a problem hiding this comment.
lgtm, tested and fixes the issue
| ) | ||
|
|
||
| func addPrintFlags() { | ||
| sybil.FLAGS.OP = flag.String("op", "avg", "metric to calculate, either 'avg' or 'hist'") |
Collaborator
There was a problem hiding this comment.
some of these seem like query flags, especially "OP" and "SAMPLES"
| sybil query -dir db-1 -table a -encode-flags ${flags}> f1.gob | ||
| cat f1.gob | sybil query -decode-flags -encode-results > results/r1.gob | ||
|
|
||
| sybil query -dir db-2 -table a -encode-flags ${flags}> f2.gob |
Collaborator
There was a problem hiding this comment.
why do you need to make f2.gob? because of the -dir flag?
okayzed
pushed a commit
that referenced
this pull request
Oct 9, 2018
* [aggregate] properly populate PrintSpec in cmd_aggregate * [scripts] add simple aggregation harness
okayzed
pushed a commit
that referenced
this pull request
Oct 9, 2018
* [aggregate] properly populate PrintSpec in cmd_aggregate * [scripts] add simple aggregation harness
okayzed
pushed a commit
that referenced
this pull request
Oct 10, 2018
* [aggregate] properly populate PrintSpec in cmd_aggregate * [scripts] add simple aggregation harness
okayzed
pushed a commit
that referenced
this pull request
Oct 10, 2018
* [aggregate] properly populate PrintSpec in cmd_aggregate * [scripts] add simple aggregation harness
okayzed
pushed a commit
that referenced
this pull request
Oct 10, 2018
* [aggregate] properly populate PrintSpec in cmd_aggregate * [scripts] add simple aggregation harness
okayzed
pushed a commit
that referenced
this pull request
Oct 11, 2018
* [aggregate] properly populate PrintSpec in cmd_aggregate * [scripts] add simple aggregation harness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#61 missed this point of PrintSpec population which causes some options to be ignored in aggregation