Skip to content

refactor(game-client): simplify chat and guild helpers#739

Merged
kamilwronka merged 1 commit intomainfrom
develop
Apr 14, 2026
Merged

refactor(game-client): simplify chat and guild helpers#739
kamilwronka merged 1 commit intomainfrom
develop

Conversation

@kamilwronka
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d1b7b9f8-bc66-4657-9ec0-a8a770ffd61d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b273ff9b9a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}),
select: (response) => response.data,
refetchOnMount: true,
refetchOnMount: false,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Refetch stale guild data when mounting useGuilds

Setting refetchOnMount to false here can leave user-guilds stale for long periods because this app persists React Query cache (maxAge 15 minutes in src/lib/query-client.ts) and also disables window-focus refetch globally. In practice, after guild membership/name changes, components that depend on useGuilds (e.g. guild switcher/chat/notifications/timers) can continue using outdated guild IDs and labels until manual invalidation, which is a functional regression from the previous mount-refetch behavior for stale data.

Useful? React with 👍 / 👎.

@kamilwronka kamilwronka merged commit 2978e5a into main Apr 14, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant