Conversation
Feature/notifications enhancements
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lootlog-docs | 22cb4f8 | Commit Preview URL Branch Preview URL |
Apr 17 2026, 08:06 AM |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22cb4f8683
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const seededNotifications = data.hasStoredNotifications | ||
| ? data.notifications | ||
| : createNotificationsSettings(guildIds); |
There was a problem hiding this comment.
Guard seeding until guild list is successfully loaded
When useGuilds() fails, React Query can report isFetched=true while guilds is still undefined; this effect then seeds notifications with createNotificationsSettings([]), marks them as stored, and persists that empty guildIds config. Because the account is added to seededAccountsRef, it won't be reseeded later after guilds recover, so notification filtering can stay permanently empty for that account.
Useful? React with 👍 / 👎.
No description provided.