Add more sample name options#10
Open
troycomi wants to merge 2 commits intolparsons:masterfrom
Open
Conversation
- Added an argument to get_samplename_list so samples can be matched with population, superpopulation or sample. - Added options to specify modern super population and archaic sample - Changed logic of parser so none of those are required. Instead, check if either list is empty and raise an exception if so indicating which options should be specified.
lparsons
requested changes
Jul 27, 2021
Owner
lparsons
left a comment
lparsons
left a comment
There was a problem hiding this comment.
Thanks for the addition, it looks good to me!
Before we merge, could we add a note to the changelog and bump the version number?
Collaborator
Author
|
Will add in the next push. It will be a few days before the empirical data is run through. |
- Added option to match superpopulation of query to population of the null database. Necessary for current simulation framework. - Bumped version number - Updated changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with population, superpopulation or sample.
check if either list is empty and raise an exception if so indicating
which options should be specified.