Update lua_getinfo/auxgetinfo to set lua_Debug::what to "Luau" instead of "Lua" when it's a Luau closure#2023
Open
PhoenixWhitefire wants to merge 11 commits intoluau-lang:masterfrom
Open
Conversation
… the closure is a Luau closure
…ead of "Lua" I checked for case-sensitive matches for "Lua" in quotes as well and got no other results
Contributor
Author
|
Added flag I only made this PR because I noticed this in my debugger attempts 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while prototyping a debugger. I would think it's one of the few places where the VM might still outwardly report the language as "Lua" instead of "Luau", maybe the last one.
Passed
Luau.UnitTestandLuau.Conformance(with-O2,--codegen -O2and--flags=true) locallyThe "
what" oflua_Debugis not reported to Scripts throughdebug.infoso I assume that there aren't any backwards-compatibility issuesAdds flag
LuauActivationRecordStopDeadnaming