Set API definition if compile language is C++#2027
Open
Jan200101 wants to merge 1 commit intoluau-lang:masterfrom
Open
Set API definition if compile language is C++#2027Jan200101 wants to merge 1 commit intoluau-lang:masterfrom
Jan200101 wants to merge 1 commit intoluau-lang:masterfrom
Conversation
|
Tried on my mixed C/C++ project, works flawlessly, gets rid of ugly workarounds. |
|
Could this please be merged when you get the chance? It’s a really solid contribution and would be great to have in. Thank you all for the incredible work you’re doing on this project. It’s always impressive to see the level of care and quality that goes into everything. |
`extern "C"` is only valid in C++, other languages may incorrectly interpret it or outright fail compilation.
8c0f5e3 to
8c86ce0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same as #933 but using generator expression which can be used since the project upgraded to cmake 3.10.
This seems to work flawlessly but there are likely some edge cases I did not consider, similar to #933.
Without this PR there are a lot of errors due to
extern "C"not being valid in C:https://github.com/Jan200101/luau-c-test test repo that prints the
_VERSIONvalue in C and C++, the luau repo is commented out in the CMakeLists.txt but can be re-enabled to see the error that would happen without this PR.