Attach trailing trivia to tokens#102
Merged
aatxe merged 1 commit intoluau-lang:primaryfrom Apr 22, 2025
Merged
Conversation
1ec5d7c to
2647b8c
Compare
aatxe
approved these changes
Apr 22, 2025
green-real
pushed a commit
to green-real/lute
that referenced
this pull request
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up to #71, this PR starts adding trailing trivia to tokens.
Trivia on a token is split up into leading and trailing trivia. Leading / trailing split is based on the Roslyn Compiler trivia rules: trailing trivia consists of everything up to and including the first
\nnewline character, and all further trivia is leading trivia of the next token. The idea being thatlocal x = ...\ncan then be represented as a single line in trivia, to allow easier replacement (rather than the\nbeing part of the next statement).This is done by: