Improve luthier to check out by revision when possible.#133
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- extern/curl.tune: Language not supported
- extern/libuv.tune: Language not supported
- extern/luau.tune: Language not supported
- extern/uWebSockets.tune: Language not supported
- extern/wolfssl.tune: Language not supported
Comments suppressed due to low confidence (1)
tools/luthier.py:290
- The update logic for an existing dependency always uses the revision even if the installed git version may not support it. Consider adding a version check here and falling back to using the branch when dealing with older versions of git.
check(call(['git', 'fetch', '--depth=1', 'origin', dependency['revision']]))
Co-authored-by: Copilot <[email protected]>
green-real
pushed a commit
to green-real/lute
that referenced
this pull request
May 19, 2025
While we currently have a pretty sane set of dependencies, we're technically vulnerable to a possible supply chain attack right now relying solely on git tags. As it turns out, very conveniently, git has _finally_ added support for checking out a single revision directly in the latest git version, `git 2.49.0`. So, we're now able to use revisions instead for anyone with the latest `git` installed. --------- Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we currently have a pretty sane set of dependencies, we're technically vulnerable to a possible supply chain attack right now relying solely on git tags. As it turns out, very conveniently, git has finally added support for checking out a single revision directly in the latest git version,
git 2.49.0. So, we're now able to use revisions instead for anyone with the latestgitinstalled.