CST: Improve serialization of functions, handle AstTypeFunction#275
Merged
CST: Improve serialization of functions, handle AstTypeFunction#275
Conversation
aatxe
approved these changes
May 12, 2025
green-real
pushed a commit
to green-real/lute
that referenced
this pull request
May 19, 2025
…-lang#275) This PR introduces support for serializing an AstTypeFunction. The most interesting part of this is the parameters, where the name (and hence colon) is optional. For this, we introduce a type `AstTypeFunctionParameter` to contain this information. We also serialize the vararg annotation independently. As part of this, we also extend the serialization on normal functions to include attributes, varargs, and the return type. For now we serialize a placeholder for the `:` token (in functions and for AstLocal too), which will get fixed after we sync to Luau 0.673.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for serializing an AstTypeFunction. The most interesting part of this is the parameters, where the name (and hence colon) is optional. For this, we introduce a type
AstTypeFunctionParameterto contain this information. We also serialize the vararg annotation independently.As part of this, we also extend the serialization on normal functions to include attributes, varargs, and the return type.
For now we serialize a placeholder for the
:token (in functions and for AstLocal too), which will get fixed after we sync to Luau 0.673.