Fix functions returned from luau.load not being able to call require#301
Merged
vrn-sn merged 5 commits intoluau-lang:primaryfrom Jun 3, 2025
Merged
Fix functions returned from luau.load not being able to call require#301vrn-sn merged 5 commits intoluau-lang:primaryfrom
luau.load not being able to call require#301vrn-sn merged 5 commits intoluau-lang:primaryfrom
Conversation
…otherwise insert '@' at the start and use as chunkname
green-real
force-pushed
the
luau-load-require-fix
branch
from
ba87d27 to
6976c13
Compare
vrn-sn
reviewed
May 30, 2025
Member
vrn-sn
left a comment
vrn-sn
left a comment
There was a problem hiding this comment.
Happy to discuss more, left some comments.
vrn-sn
reviewed
Jun 2, 2025
vrn-sn
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
luau.loadcurrently doesn't pass a valid chunkname toluau_loadthat can be used to handle calls torequire. This PR fixes that by retrieving the source path of the caller usinglua_getinfo. If no second argument was passed and if the source path of the caller couldn't be retrieved,luau.loadwill throw an error.This PR also changes
luau.loadso that the second argument is considered a path, relative to the current working directory. This path is converted to a proper chunk name by inserting '@' at the start.