Runtime type definitions setup#304
Merged
aatxe merged 17 commits intoluau-lang:primaryfrom Jul 17, 2025
Merged
Conversation
We don't talk about the removal.
aatxe
reviewed
May 30, 2025
Member
aatxe
left a comment
aatxe
left a comment
There was a problem hiding this comment.
Looks pretty good, I would say you can split the remaining definition file additions into its own PR though since they're kinda orthogonal changes.
aatxe
reviewed
May 30, 2025
Contributor
|
All type definition luau changes can be removed from this PR - extracted to and expanded in #351 |
aatxe
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in
cli/commands/setup, which puts type definitions in the user directory. This PR also adds some type definitions to the remaining Lute libraries.Type definition files are put into
~/.lute/typedefs/0.1.0/. We autogenerate thedefinitionsfile into a singulargenerated-types.luaufile, containing a table{ [fileName]: fileContent }. Upon usage of thesetupcommand, we write this table into the type definition directory.