Closed
Conversation
aatxe
requested changes
Mar 2, 2025
Member
aatxe
left a comment
aatxe
left a comment
There was a problem hiding this comment.
Looks good to me, besides the nit about vm.create
Member
|
Looks like the CI setup isn't quite right though? |
Co-authored-by: ariel <aweiss@hey.com>
Some luau bugs, but also Luau doesn't like the forward declared `serialize_any` and `deserialize` functions using a local, so we switch it to a normal function.
Collaborator
Author
Was waiting on the other PRs. A rebase fixed it now, but we do get a lot of type errors. Will try and fix some of them. |
Member
|
Saw this PR was closed. Are we good to delete the branch? |
Collaborator
Author
|
Yeah should be fine (would be nice to get analyze running in CI someday) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
lute --checkcommand. This is copied fromluau-analyze@lute. This alias is registered in the.luaurcfileA couple points:
LuauSolverV2is force-enabled) for dogfooding purposes.Still need to fix some type errors