Draft
Conversation
I think they adjusted the format slightly. I just ran
npm install --legacy-peer-deps
with npm 10.9.3 (not the latest).
Just keeping things up to date.
Mostly keeping things up to date but also we were mixing 7.x and 8.x packages there so this patch also resolves that problem.
jstasiak
requested review from
a team,
0bex0,
charcarr,
jasharifestina,
raguiar9080 and
rbruggem
Not detected right now but newer typescript-eslint packages pick these up: * If we assert we're only dealing with AxiosError and derivatives isAxiosError can never be false so throw error throws a value of type never -> linting problem. * err was unused.
rbruggem
approved these changes
Aug 4, 2025
Contributor
Author
|
I think this requires |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly keeping things up to date but also we were mixing 7.x and 8.x packages there so this patch also resolves that problem.