Create Blocker Comments and Fix Previous Anchor Issue#26
Open
lrv1668 wants to merge 4 commits intolvermeulen:mainfrom
Open
Create Blocker Comments and Fix Previous Anchor Issue#26lrv1668 wants to merge 4 commits intolvermeulen:mainfrom
lrv1668 wants to merge 4 commits intolvermeulen:mainfrom
Conversation
Author
|
@lvermeulen Any update on when this could be merged? |
|
@lvermeulen , any updates on this? |
|
@lvermeulen This would be a helpful change, could you please review and merge if things look good? |
|
@lvermeulen Would still love to see this merged, as it would provide some functionality we were hoping to see in this package. |
|
related #28 |
|
Hello guys, any updates regarding blocker comments PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is used to add functionality to create blocker comments (which is the exact same payload as /comments).
I also fixed the formatting for the anchor in the payload, as it would cause a 500 HTTP response if all values were null.
Anyone please feel free to add functions for the other HTTP methods for /blocker-comments, my priority is only to get creation working for now.