use lvgl_esp32_drivers version with ttgo fix#348
Open
liamHowatt wants to merge 1 commit intolvgl:masterfrom
Open
use lvgl_esp32_drivers version with ttgo fix#348liamHowatt wants to merge 1 commit intolvgl:masterfrom
liamHowatt wants to merge 1 commit intolvgl:masterfrom
Conversation
There was a problem hiding this comment.
cubic analysis
No issues found across 1 file. Review in cubic
Member
|
Can we archive this repo in favor of https://github.com/lvgl/lv_esp_idf? |
Author
|
Yes I think we should encourage new developments to take place in lv_esp_idf. This repo "finished" in a sense. It has a lot of value. I don't think we should archive it because we won't be able to do fixes like this. |
Member
|
Note that these repos are still If it's possible and makes sense, we can
What do you think? |
Member
|
Maybe the way to replace lv_port_esp32 is to create a special ESP board in lv_esp_idf (also add a manifest) which uses display controllers with any ESP chip/module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #317
Bump the lv_esp32_drivers submodule to the first version with the fix for #317
Summary by cubic
Updated the lvgl_esp32_drivers submodule to include the TTGO display fix required by issue #317.