Skip to content

replace of the "fence" changes from PR #550#552

Draft
evaleev wants to merge 1 commit intomasterfrom
evaleev/replay/pf-550-fence-ensures-ntask-is-zero
Draft

replace of the "fence" changes from PR #550#552
evaleev wants to merge 1 commit intomasterfrom
evaleev/replay/pf-550-fence-ensures-ntask-is-zero

Conversation

@evaleev
Copy link
Copy Markdown
Contributor

@evaleev evaleev commented Oct 11, 2024

#550 (namely, 6ab4484) introduced change in fence semantics that ensure that:

  • local # of tasks is zero after reading AM counts
  • repeat global termdet after epilogue/cleanup

this caused hangs in various parts of TiledArray when running in Github Action Runners (but not elsewhere). 93a9a5c reverted it. This PR contains these changes for reconsideration.

for this we ensure that:
- local # of tasks is zero after reading AM counts
- repeat global termdet after epilogue/cleanup

(cherry picked from commit 6ab4484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant