Skip to content

wesnoth: update to 1.18.7#32087

Open
herbygillot wants to merge 1 commit intomacports:masterfrom
herbygillot:wesnoth-1.18.7
Open

wesnoth: update to 1.18.7#32087
herbygillot wants to merge 1 commit intomacports:masterfrom
herbygillot:wesnoth-1.18.7

Conversation

@herbygillot
Copy link
Copy Markdown
Member

Builds successfully, but it doesn't seem to start up on Tahoe, perhaps due to X11 limitations on that platform.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link
Copy Markdown

Notifying maintainers:
@ryandesign for port wesnoth.

@macportsbot macportsbot added type: update maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Apr 6, 2026
@ryandesign
Copy link
Copy Markdown
Contributor

perhaps due to X11 limitations on that platform

Are there new X11 limitations on Tahoe?

# Change github.tarball_from to 'releases' or 'archive' next update
github.tarball_from tarball
github.setup wesnoth wesnoth 1.18.7
github.tarball_from archive
Copy link
Copy Markdown
Contributor

@ryandesign ryandesign Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When projects provide release distfiles, we should use them. We should not switch to automatically-generated git tarballs. This project's bz2 release files are smaller than GitHub's gz files, and release files do not suffer from the specter of changing unexpectedly in the future.

The github.tarball_from tarball line and the comment about switching it to archive were added to ports in bulk, and it was erroneous for them to have been added to this port since it overrode that with its own master_sites.

Suggested change
github.tarball_from archive

The master_sites and use_bzip2 lines below should be restored and checksums should be updated accordingly.

port:libvorbis \
path:lib/pkgconfig/pango.pc:pango \
port:pcre \
port:lua54 \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list of dependencies was intended to be sorted alphabetically by port name. It's not entirely perfect, with readline being out of order, but let's not add to the problem here. lua54 sorts between libvorbis and pango. If you want to move readline to the right place that would be great too.

Comment on lines +4 to +6
PortGroup github 1.0
PortGroup cmake 1.1
PortGroup app 1.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to change the formatting of the portgroup lines. Different maintainers might have different opinions of style, and this is the style I use.

Suggested change
PortGroup github 1.0
PortGroup cmake 1.1
PortGroup app 1.0
PortGroup github 1.0
PortGroup cmake 1.1
PortGroup app 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: update

Development

Successfully merging this pull request may close these issues.

3 participants