Conversation
|
Notifying maintainers: |
Are there new X11 limitations on Tahoe? |
games/wesnoth/Portfile
Outdated
| # Change github.tarball_from to 'releases' or 'archive' next update | ||
| github.tarball_from tarball | ||
| github.setup wesnoth wesnoth 1.18.7 | ||
| github.tarball_from archive |
There was a problem hiding this comment.
When projects provide release distfiles, we should use them. We should not switch to automatically-generated git tarballs. This project's bz2 release files are smaller than GitHub's gz files, and release files do not suffer from the specter of changing unexpectedly in the future.
The github.tarball_from tarball line and the comment about switching it to archive were added to ports in bulk, and it was erroneous for them to have been added to this port since it overrode that with its own master_sites.
| github.tarball_from archive |
The master_sites and use_bzip2 lines below should be restored and checksums should be updated accordingly.
games/wesnoth/Portfile
Outdated
| port:libvorbis \ | ||
| path:lib/pkgconfig/pango.pc:pango \ | ||
| port:pcre \ | ||
| port:lua54 \ |
There was a problem hiding this comment.
This list of dependencies was intended to be sorted alphabetically by port name. It's not entirely perfect, with readline being out of order, but let's not add to the problem here. lua54 sorts between libvorbis and pango. If you want to move readline to the right place that would be great too.
games/wesnoth/Portfile
Outdated
| PortGroup github 1.0 | ||
| PortGroup cmake 1.1 | ||
| PortGroup app 1.0 |
There was a problem hiding this comment.
I would prefer not to change the formatting of the portgroup lines. Different maintainers might have different opinions of style, and this is the style I use.
| PortGroup github 1.0 | |
| PortGroup cmake 1.1 | |
| PortGroup app 1.0 | |
| PortGroup github 1.0 | |
| PortGroup cmake 1.1 | |
| PortGroup app 1.0 |
f902dbf to
75c7916
Compare
Builds successfully, but it doesn't seem to start up on Tahoe, perhaps due to X11 limitations on that platform.
Verification
Have you
port lint?sudo port test?sudo port -vst install?