Skip to content

XviD: set C version to 1999#32129

Merged
herbygillot merged 1 commit intomacports:masterfrom
herbygillot:XviD-c23-bool
Apr 8, 2026
Merged

XviD: set C version to 1999#32129
herbygillot merged 1 commit intomacports:masterfrom
herbygillot:XviD-c23-bool

Conversation

@herbygillot
Copy link
Copy Markdown
Member

In C23, bool is a built-in keyword. Guard the typedef int bool; in encoder.h so it is only used with older C standards.

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot macportsbot added maintainer: none by: member Created by a member with commit rights labels Apr 8, 2026
@reneeotten
Copy link
Copy Markdown
Contributor

probably caused by the autoconf update - see @ryandesign message on the mailinglist. Instead of patching you could probably also set upstream's required, and probably older, standard than C23.

@herbygillot
Copy link
Copy Markdown
Member Author

herbygillot commented Apr 8, 2026

probably caused by the autoconf update - see @ryandesign message on the mailinglist. Instead of patching you could probably also set upstream's required, and probably older, standard than C23.

Good point, thanks @reneeotten.

@herbygillot herbygillot changed the title XviD: fix build with C23 XviD: set C version to 1999 Apr 8, 2026
@herbygillot herbygillot merged commit 7db4134 into macports:master Apr 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

by: member Created by a member with commit rights maintainer: none

Development

Successfully merging this pull request may close these issues.

3 participants