Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Add information about ignoreTmpls property#6873

Merged
dobooth merged 4 commits into
magento:masterfrom
serhiyzhovnir:add-information-about-ignoreTmpls-property
Mar 25, 2020
Merged

Add information about ignoreTmpls property#6873
dobooth merged 4 commits into
magento:masterfrom
serhiyzhovnir:add-information-about-ignoreTmpls-property

Conversation

@serhiyzhovnir

@serhiyzhovnir serhiyzhovnir commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

@devops-devdocs

Copy link
Copy Markdown
Collaborator

An admin must run tests on this PR before it can be merged.

defaults: {
value: 'some component value',
property: '${ $.value }', // equal to 'some component value' after component initialization
propertyIgnoreTempls: '${ $.value }', // equal to '${ $.value }' after component initialization

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part might be confusing. We may either remove property or add an extra comment for propertyIgnoreTempls that propertyIgnoreTempls is the property for which template literals will be ignored. Also, we may add an extra comment to ignoreTmpls that this section contains list of properties with template literals ignored.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you!

@rogyar rogyar added the Technical Updates to the code or processes that alter the technical content of the doc label Mar 16, 2020
@serhiyzhovnir

Copy link
Copy Markdown
Contributor Author

Hi @rogyar
The PR was adjusted.
Could you, please, check it again.
Thank you!

@serhiyzhovnir serhiyzhovnir requested a review from rogyar March 25, 2020 13:32
@dobooth dobooth added Major Update Significant original updates to existing content 2.3.x Magento 2.3 related changes and removed Technical Updates to the code or processes that alter the technical content of the doc labels Mar 25, 2020
@dobooth

dobooth commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

running tests

@dobooth dobooth merged commit b95bb18 into magento:master Mar 25, 2020
@ghost

ghost commented Mar 25, 2020

Copy link
Copy Markdown

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants