-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Agent chat: terminal theme tokens + in-conversation search #6006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lawrencecchen
wants to merge
6
commits into
feat-agchat-rich-tools
Choose a base branch
from
feat-agchat-theme-search
base: feat-agchat-rich-tools
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cbb176f
Agent chat: deliver terminal theme tokens through the agent-session t…
lawrencecchen 5b55738
Agent chat: in-conversation search (Cmd+F, counter, next/prev, filter…
lawrencecchen 1625595
Search: incremental match cache + index the visible tool input fields
lawrencecchen 9c8d085
Search bar: focus the input only on first mount
lawrencecchen 864b7c5
Search bar: do not intercept Enter/Escape during IME composition
lawrencecchen 41a140c
Search: match argv commands, edit pairs, and file contents in tool in…
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 4 additions & 4 deletions
8
Resources/markdown-viewer/webviews-app/chunks/agentChatSurface.mjs
Large diffs are not rendered by default.
Oops, something went wrong.
14 changes: 7 additions & 7 deletions
14
Resources/markdown-viewer/webviews-app/chunks/diffSurface.mjs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openSearchis recreated as a new arrow function on every render, souseSearchHotkey's[onOpen]dependency changes every render and the effect runs cleanup+setup on everyAgentChatApprender. This directly contradicts the hook's documented invariant ("attaches exactly one keydown listener for the component's lifetime"). During streaming (frequent renders) the listener is re-attached on every incoming event. Wrapping inuseCallbackwith an empty dependency array is safe becausedispatchSearchfromuseReduceris guaranteed stable.