Fix import paths in callback.d.ts#351
Open
WikiRik wants to merge 1 commit intomariadb-corporation:mainfrom
Open
Fix import paths in callback.d.ts#351WikiRik wants to merge 1 commit intomariadb-corporation:mainfrom
WikiRik wants to merge 1 commit intomariadb-corporation:mainfrom
Conversation
Follow-up fix for mariadb-corporation#346
Author
|
I believe the failing MariaDB 12.3 dev CI job is not due to my changes; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fix for #346
I've asked AI how we might be able to do a regression test for this, as I'm not very familiar with the internals of this project. That came up with testing declarations through a new tsconfig.json file with tsc. I can add something like that if that's something that maintainers think is useful.