Skip to content

fix: Apply already selected section#2

Merged
maro114510 merged 5 commits intomainfrom
fix/selected-sections
Jan 6, 2026
Merged

fix: Apply already selected section#2
maro114510 merged 5 commits intomainfrom
fix/selected-sections

Conversation

@maro114510
Copy link
Copy Markdown
Owner

Merge Overview

This pull request significantly refactors and improves the structure and user experience of the Feedly Read Later opener extension. The main changes include a major reorganization of content.js for clarity and maintainability, and the introduction of a loading animation and feedback system in the popup UI. These enhancements make the codebase easier to navigate and the extension more user-friendly by providing clear visual feedback during operations.

Codebase organization and maintainability:

  • Added section comments and reorganized content.js into thematic blocks (Constants, Utility Functions, Save State Detection, Button Detection, Entry Processing, Event Dispatching, Infinite Scroll Loading, Main Handler, Message Listener) for better readability and maintainability. [1] [2] [3] [4] [5] [6] [7] [8]

Saved entry detection improvements:

  • Refactored and improved saved state detection with a new quickCheckSaved function, and clarified the logic for finding the correct "unsave" button. This makes entry processing more robust and efficient. [1] [2]

Popup UI enhancements:

  • Introduced a loading animation and feedback system in the popup, including a spinner, loading messages, and visual success/error states, with corresponding CSS and HTML updates (popup.css, popup.html). [1] [2]
  • Added a LoadingManager object in popup.js to control the loading animation and feedback, and integrated it into the main run flow for user feedback during processing. [1] [2] [3] [4] [5] [6] [7]

General improvements:

  • Added section comments and grouped related functions in popup.js for better code clarity. [1] [2] [3] [4]

These changes collectively improve both the developer experience (through clearer code structure) and the user experience (through responsive UI feedback).

@maro114510 maro114510 self-assigned this Jan 6, 2026
Copilot AI review requested due to automatic review settings January 6, 2026 06:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the Feedly Read Later opener extension to improve code organization and user experience. The changes add visual feedback during operations through a loading animation system, while reorganizing the codebase with clear section comments for better maintainability.

  • Added a LoadingManager to provide loading, success, and error visual feedback in the popup UI
  • Reorganized content.js and popup.js with section comments grouping related functionality (Constants, Utility Functions, Save State Detection, etc.)
  • Introduced quickCheckSaved function to optimize entry processing by pre-filtering unsaved entries before DOM operations

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
popup.js Added LoadingManager object with loading/success/error states, integrated into the run function, and added section comments for code organization
popup.html Added loading container with spinner and text elements, including accessibility attributes
popup.css Added styles for loading animation, spinner states (error/success), and button loading states
manifest.json Version bumped to 0.2.0 and reformatted arrays for better readability
content.js Reorganized with section comments, moved functions to thematic blocks, and added quickCheckSaved optimization function
.editorconfig Added specific indentation rules for JS, CSS, and JSON files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread popup.js
Comment thread content.js
@maro114510 maro114510 merged commit 9881868 into main Jan 6, 2026
1 check passed
@maro114510 maro114510 deleted the fix/selected-sections branch January 6, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants