Add descriptions for S3 env variables#987
Closed
jgillich wants to merge 1 commit intomastodon:mainfrom
Closed
Conversation
helix2301
approved these changes
Nov 7, 2022
helix2301
left a comment
helix2301
left a comment
There was a problem hiding this comment.
The wording does sound better and provides more detail than previous documentation.
Closed
|
It would be nice if |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Contributor
|
I've just opened #1393 which addresses these same issues and many more (including answering some of the questions this PR's creator never got answers to). Maybe that one will get reviewed and merged :-) |
Contributor
|
That linked PR - #1393 - did in fact merge. Going to close this one since that merged and this needs rebase ... but if there's something obvious/useful/etc in here which was not in the other one and would still improve the docs, please reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found some of them confusing, so here are some descriptions. Does S3_ENDPOINT override S3_HOSTNAME and S3_PROTOCOL? Wasn't sure about that, could potentailly add a note
Also removed some uses of the word extremely because the circumstances weren't all that extreme 😄