Invites marked `expired` still appear in list filtered for `available`

[meldra]

Steps to reproduce the problem

1. Be on the admin/invites page
2. Select the Filter option Available
3. See a list filtered of some of the Expired invites,
4. But still labels half of the results as Expired

Expected behaviour

All of the expired invites marked as Expired should be filtered out

Actual behaviour

Half of the results are Expired

Detailed description

No response

Mastodon instance

fosstodon.org and others

Mastodon version

v4.5.9

Browser name and version

All

Operating system

All

Technical details

The definition of "expired" seems to be somewhat arbitrary.

[ClearlyClaire]

I believe what happens is the following:

• “Available” lists all invite links that have not expired yet, even if they are not actually usable
• there are more reasons that may make an invite invalid: it reached its maximum uses, or the user who created the invite does not have a usable account anymore (suspended, moved, turned into memoriam, …)
• the interface currently says “Expired” for all of the above cases

[meldra]

Related and mildly offtopic: there are a whole bunch of deficiencies in admin/invites, to the point the whole workflow needs a big thinky think. Not least because invites are featuring more in spam workflows than previously (hence #38594 that I opened recently).

How does this project manage refactors like that and how would one get some motion for one?