Docker: Use precompiled jemalloc, format, apply hadolint suggestions#10823
Docker: Use precompiled jemalloc, format, apply hadolint suggestions#10823Gargron merged 3 commits intomastodon:mainfrom SuperSandro2000:docker-liballoc
Conversation
|
This needs some more work as the compiled ruby did not pickup jemalloc. Edit: Apparently the live image does not return jemalloc flags with Edit2: Apparently now you need to use Edit3: Both the old and new now return the correct libs. Edit4: |
|
Don't commit atm.. ubuntu 19.04 should be fine, but 18.04 is still considered the stable/latest. |
|
Latest is 19.04, lts is 18.04. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I hate stale bot |
|
@SuperSandro2000 Can you resolve conflicts? |
|
I can do this later today. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
bump |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@SuperSandro2000 feel free to update this for 20.04... and I'll test it out |
SuperSandro2000
changed the title
|
@shleeable Updated the PR. |
|
Seeing this has 2 approvals already, is there an ETA for merging this? It's kinda a blocker for getting Mastodon running on arm64 machines. |
|
Re-run Circle CI workflow |
|
What is blocking this still? |
A merge conflict which I just solved. |
|
Can this finally be merged? This reduces the complexity of the Dockerfile by a lot. |
|
@SuperSandro2000 Could you fixed the conflicts? Hoping this gets merged... 🙏 |
|
@jaredallard yeah, probably not. |
|
Looks good to me, I don't know why the CI didn't run though. Could you rebase and force-push? |
Done. Lets see what happens. |
…astodon#10823) * Format, apply hadolint suggestions, little nitpicks * Use pre compiled jemalloc * Use tini from package repository
7 participants
I noticed that 19.04 has precompilled jemalloc packages and I think this should be worth the upgrade. Of course it would need some testing if 19.04 breaks anything but those tests need to be done sooner than later anyway for people running on bare metal and Ubuntu 19.04.