Improvement variable height in single column layout#10917
Merged
Gargron merged 2 commits intomastodon:masterfrom Jun 2, 2019
Conversation
Contributor
Author
|
Now that we have confirmed the operation on Microsoft Edge, remove the WIP. However, my changes have made AutosuggestTextarea go beyond its original role. This requires splitting, but I do not know how to write the appropriate code. Someone, please merge this PR and then refactor it. |
noellabo
changed the title
Gargron
approved these changes
Jun 2, 2019
This was referenced Jun 4, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Improvement variable height of compose and navigation panel in single column layout * Fix wrong quotes and missing commas
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
* Improvement variable height of compose and navigation panel in single column layout * Fix wrong quotes and missing commas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improvement to make the height of compose panel and navigation panel in single column layout variable from fixed length.
In the case where the compose panel has the longest vertical length, the following is assumed.
I made adjustments to make it possible to display this at the same time.
Also for the navigation panel, the vertical length gets longer depending on the number of lists, so we scroll only when necessary.
Check the animated GIF for behavior.
