Add label for admin theme selector#11121
Merged
Gargron merged 3 commits intomastodon:masterfrom Jun 19, 2019
Merged
Conversation
Gargron
reviewed
Jun 19, 2019
Member
Gargron
left a comment
Gargron
left a comment
There was a problem hiding this comment.
What about setting_theme? I am confused
Member
|
Oh this is for the admin settings, I see. Wouldn't it be easier to make the form explicitly use setting_theme label though? To avoid adding another translation |
Contributor
Author
|
Oh, right. I considered it, but only as directly replacing :theme with :setting_theme and refactoring accordingly, I didn't think of just changing the label. |
alixrossi
changed the title
added 2 commits
June 19, 2019 15:51
Gargron
approved these changes
Jun 19, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Add simple_form default for admin theme selector * Revert "Add simple_form default for admin theme selector" This reverts commit 0b736f7. * Add setting_theme label to admin theme selector
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
* Add simple_form default for admin theme selector * Revert "Add simple_form default for admin theme selector" This reverts commit 0b736f7. * Add setting_theme label to admin theme selector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the "theme" label in Administration/Site settings not having a translation string, and thus falling back to
human_attribute_name. As an example: