Skip to content

Unliking a post updates like count on front end #12140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gargron merged 7 commits into from
Oct 24, 2019
Merged

Unliking a post updates like count on front end #12140

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b9413c5
return the new favourites_count
NimaBoscarino Oct 10, 2019
39923a8
Remove trailing whitespace
NimaBoscarino Oct 10, 2019
37aacd6
revert changes to favourites_controller
NimaBoscarino Oct 10, 2019
b0c3222
Merge branch 'master' of github.com:tootsuite/mastodon
NimaBoscarino Oct 10, 2019
202ccbf
Decrease favourites_count through statuses reducer
NimaBoscarino Oct 10, 2019
80459ec
styling fix
NimaBoscarino Oct 10, 2019
abec999
Fix missing trailing comma
NimaBoscarino Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/javascript/mastodon/reducers/statuses.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
REBLOG_FAIL,
FAVOURITE_REQUEST,
FAVOURITE_FAIL,
UNFAVOURITE_SUCCESS,
} from '../actions/interactions';
import {
STATUS_MUTE_SUCCESS,
Expand Down Expand Up @@ -37,6 +38,9 @@ export default function statuses(state = initialState, action) {
return importStatuses(state, action.statuses);
case FAVOURITE_REQUEST:
return state.setIn([action.status.get('id'), 'favourited'], true);
case UNFAVOURITE_SUCCESS:
const favouritesCount = action.status.get('favourites_count');
return state.setIn([action.status.get('id'), 'favourites_count'], favouritesCount - 1);
Copy link
Copy Markdown
Member

@Gargron Gargron Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more concise way of writing this is:

return state.updateIn([action.status.get('id'), 'favourites_count'], x => Math.max(x - 1, 0));

case FAVOURITE_FAIL:
return state.get(action.status.get('id')) === undefined ? state : state.setIn([action.status.get('id'), 'favourited'], false);
case REBLOG_REQUEST:
Expand Down
⚡