Drop filtered messages if the filter is “irreversible”#12172
Closed
ClearlyClaire wants to merge 4 commits intomastodon:masterfrom
Closed
Drop filtered messages if the filter is “irreversible”#12172ClearlyClaire wants to merge 4 commits intomastodon:masterfrom
ClearlyClaire wants to merge 4 commits intomastodon:masterfrom
Conversation
Member
If I'm not mistaken it never happens in Mastodon..? |
Contributor
Author
|
Thinking a bit more about it, it probably never occurs in the So the usefulness is pretty limited in Mastodon itself, as it only prevents TL lists to fill up with old dropped toots, the only user-facing consequence of that being old toots cleaned up “too early” (the 40 items thing) if space in-between was occupied by dropped toots. |
… instead of adding them to the timelines and then not showing them. This fixes timelines showing new items when the only new items are “irreversibly” filtered toots. This may be an edge case in Mastodon/glitch-soc, but it is not in Pleroma, which does no filtering server-side whatsoever. Signed-off-by: Thibaut Girka <thib@sitedethib.com>
Signed-off-by: Thibaut Girka <thib@sitedethib.com>
Signed-off-by: Thibaut Girka <thib@sitedethib.com>
ClearlyClaire
force-pushed
the
fixes/filter-drop
branch
from
f01a316 to
372e871
Compare
Keeping them in the TL fixes the front-end not being able to properly keep track of pagination. Furthermore, filtered toots are not counted as unread content, whether they are dropped or not.
ClearlyClaire
force-pushed
the
fixes/filter-drop
branch
from
372e871 to
770b8ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… instead of adding them to the timelines and then not showing them.
This fixes timelines showing new items when the only new items are “irreversibly” filtered toots, as well as such items taking space in the client-side lists.
This is actually an edge case in Mastodon itself, but the normal case in Pleroma, which can be used with a Mastodon front-end but does not apply filters server-side.