microformat mentions can have an implicit url property#12189
Merged
Conversation
See the first example here: http://microformats.org/wiki/microformats2#hyperlinked_person
ykzts
approved these changes
Oct 20, 2019
Member
|
There is an extra span for a better underline effect on hover that does not include the at sign, we won’t remove that |
ClearlyClaire
approved these changes
Oct 22, 2019
Contributor
ClearlyClaire
left a comment
There was a problem hiding this comment.
Approved. But I think we could also skip URLs for hashtags and mentions listed in the ActivityStreams tag attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the first example here: http://microformats.org/wiki/microformats2#hyperlinked_person
see http://microformats.org/wiki/microformats2-parsing#parsing_for_implied_properties for a more detailed list of implicit property parsing rules.
We might also want to change the HTML mastodon generates at some point, since having an extra span element feels awkward to me.