Fix sample SAML_ACS_URL, SAML_ISSUER#12669
Merged
Gargron merged 1 commit intomastodon:masterfrom Dec 23, 2019
Merged
Conversation
Gargron
approved these changes
Dec 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values of SAML_ACS and SAML_ISSUER in the sample .env file are strange.
"http://localhost:3000/auth/auth/saml/callback" should be written as a sample value for SAML_ACS.
In addition, since SAML_ISSUER is a unique value representing the service provider, it is better to enter a domain name unless otherwise specified by IdP.
When actually setting up SAML, the user needs to overwrite it, so it gets confused if strange values are listed.
Thankyou!