Optimize some regex matching#15528
Merged
Gargron merged 4 commits intomastodon:mainfrom Jan 22, 2021
007lva:refactor/optimizations-using-regex-match
Merged
Optimize some regex matching#15528Gargron merged 4 commits intomastodon:mainfrom 007lva:refactor/optimizations-using-regex-match
Gargron merged 4 commits intomastodon:mainfrom
007lva:refactor/optimizations-using-regex-match
Conversation
Gargron
approved these changes
Jan 10, 2021
Contributor
Author
|
Hello, is there something I can do to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regexp#match? is faster and more proper when only matters if the regex matches or not.
https://bigbinary.com/blog/ruby-2-4-implements-regexp-match-without-polluting-global-variables