Improved performance of notification preloading#15640
Merged
Gargron merged 3 commits intomastodon:mainfrom Jan 31, 2021
Merged
Conversation
ykzts
approved these changes
Jan 30, 2021
Gargron
approved these changes
Jan 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I optimized queries because many useless queries are being executed when loading notifications (for example, unnecessary associations and N + 1 queries).
Also, I improved to stop the notification cache and use the status cache. Since notifications are used only by the logged-in user, the cache effect is low. We hope that using the status cache will increase the effectiveness of the cache.
I have confirmed the change in the development environment with the following notification. (cache is off)
before
query count: 67
after
query count: 40