Skip to content

Add notifications when a reblogged status has been updated#17404

Merged
Gargron merged 3 commits intomainfrom
feature-notify-about-updates
Feb 11, 2022
Merged

Add notifications when a reblogged status has been updated#17404
Gargron merged 3 commits intomainfrom
feature-notify-about-updates

Conversation

@Gargron
Copy link
Copy Markdown
Member

@Gargron Gargron commented Jan 31, 2022

Follow-up to #16697


Funded through the BMBF (BMBF Förderkennzeichen: 01IS21S29)

@Gargron Gargron force-pushed the feature-notify-about-updates branch from 15f9033 to d11545d Compare February 1, 2022 21:41
Comment thread app/javascript/mastodon/actions/notifications.js Outdated
@Gargron Gargron force-pushed the feature-notify-about-updates branch 3 times, most recently from 52417e2 to b75ecd6 Compare February 1, 2022 21:47
@Gargron Gargron marked this pull request as ready for review February 1, 2022 21:48
@Gargron Gargron added api REST API, Streaming API, Web Push API ui Front-end, design labels Feb 1, 2022
@Gargron Gargron requested a review from ClearlyClaire February 6, 2022 06:20
Copy link
Copy Markdown
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this notification type warrants all the notification pathways that other notification types use, but I can't see anything in this PR about:

  • web push notifications app/javascript/mastodon/service_worker/web_push_locales.js, app/javascript/mastodon/service_worker/web_push_notifications.js, app/controllers/api/web/push_subscriptions_controller.rb
  • configuring how and where to show notifications (app/javascript/mastodon/reducers/settings.js, app/javascript/mastodon/features/notifications/components/column_settings.js)
  • mail notifications

@Gargron Gargron force-pushed the feature-notify-about-updates branch from b75ecd6 to ca4f6ff Compare February 9, 2022 23:45
Comment thread app/controllers/api/web/push_subscriptions_controller.rb
Comment thread app/controllers/api/web/push_subscriptions_controller.rb
@Gargron
Copy link
Copy Markdown
Member Author

Gargron commented Feb 9, 2022

We don't have e-mail notifications for polls or new statuses, and I think it doesn't make sense for this either. I've added the other things. The notification settings are definitely too long now, and have too many things that I wouldn't care about adjusting, but it will do for now.

Copy link
Copy Markdown
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In LocalNotificationWorker, notifications are skipped if Notification.where(account: receiver, activity: activity).any?.

This means that update notifications will be missed if you have a status (subscription) notification already. Maybe that condition needs changing to include the notification type as well.

@Gargron Gargron force-pushed the feature-notify-about-updates branch from 5f2ee2d to b9f466a Compare February 11, 2022 20:15
@Gargron Gargron force-pushed the feature-notify-about-updates branch from b9f466a to 043edf6 Compare February 11, 2022 20:53
Copy link
Copy Markdown
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

There is another scenario I'm a bit worried about but I don't have an easy fix to it: suppose you're boosting someone who is silenced (e.g. someone you follow boosted them), and they then edit their post. Because they're silenced and you don't follow them, you don't get the notification.

But on the other hand, someone could be silenced precisely because they do stuff like spam in edits?

@Gargron Gargron merged commit 8f03b7a into main Feb 11, 2022
@Gargron Gargron deleted the feature-notify-about-updates branch February 11, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api REST API, Streaming API, Web Push API ui Front-end, design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants