Add bookmarks by ClearlyClaire · Pull Request #7107 · mastodon/mastodon

ClearlyClaire · 2018-04-11T18:28:25Z

Add a bookmark feature, working mostly like favourites, except they are not federated nor visible by other users than the person bookmarking a toot.

Cassolotl · 2018-04-11T20:32:15Z

This seems like a good change, I like private save-for-later as separate from public reaction hearts/stars.

Related issues:

Dream feature: "like" and "save" separately Dream feature: "like" and "save" separately #1178
arbitrary emojis as reactions arbitrary emojis as reactions #4106 - maybe the heart/star can just be like a positive reaction button and it doesn't need to be saved?

trwnh · 2018-04-13T07:51:35Z

re: what m4sk1n said -- i don't see a compelling reason to change anything about how faves work currently. fundamentally, they are a public approval / acknowledgement of a message, and can be browsed from someone's profile if they want to see go back and see them.

a bookmark feature would be almost the same thing, but private -- no indicator, not exposed via the profile or the status. adding bookmarks is no reason to remove functionality from the favorites.

Cassolotl · 2018-04-13T08:08:52Z

I feel like "like/star" doesn't really need to be saved in a list if it's just a reaction emoji ish thing - if folks want to save it for later they'll use the bookmark feature, right?

And I think probably bookmarked toots should show up in search because it's save-for-later and that'll be something you want to be able to look up later.

I think "like/star" toots don't need to show up in a search because it's just public approval and that could clog up the search results unnecessarily - most people are gonna "like/star" much more than they'll save-for-later, and they're less likely to need to pull liked toots up in searches later, right?

nightpool · 2018-04-16T18:08:28Z

disagree with adding this per my comments on #1178.

nightpool · 2018-04-16T18:08:50Z

Hmm. Not sure what happened to that issue, it seems to be completely deleted, along with discussion.

Cassolotl · 2018-04-16T18:12:35Z

@nightpool My account has been flagged, and I think it's making a lot of my issues invisible. :S I've messaged Github to find out what's going on, it could be that I've been reported, but it could also be that I've been flagged by a spam-detecting bot, so I'm not really sure what's going on!

Gargron · 2018-04-16T18:23:08Z

Archive: https://web.archive.org/web/20171226131702/https://github.com/tootsuite/mastodon/issues/1178

No idea how that issue disappeared, I did not delete it. I did not know you can delete them like that, only close...

ClearlyClaire · 2018-04-16T18:35:14Z

Ok, your main argument seems to be “web browser bookmarks serve this purpose”, yes and no.
If you bookmark the public toot, it's a pain to get back into the WebUI to boost/like/reply to it.
If you bookmark the WebUI, it's a bit better, but you go through the trouble of reloading the whole WebUI, either in an extra tab, or replacing your position in timelines, etc.

lanodan · 2018-04-16T19:19:50Z

I’m pretty sure favorite should be enhanced instead (searching in the favorites for example).
There is a save feature in friendica and I pretty much never used it and never heard of someone using it.
Also using the browser bookmarks feature (assuming your browser has bookmarks…) lacks the ability to search in the content of the message.

ClearlyClaire · 2018-04-16T19:59:56Z

@lanodan favorites are already searchable (along with the rest) if Full-Text-Search is enabled.
The point of the “bookmark” feature as I use it is to bookmark things I haven't the time to read right now but I potentially want to react on later. For instance, if someone posts a long article or a video, and I want to like/boost/comment once I've seen it.

Gargron · 2018-04-17T11:56:39Z

@ThibG But I use favourites for that use case. And that having a social function makes sense to me, I remember the old Delicious used to display rankings of favourited links and stuff that authors of those links could be proud of. I'm not a big fan of splitting this functionality. In fact, I was not a fan when Twitter changed favourites to likes, and now iirc they are adding "bookmarks" and I think that's a hot mess that could've been avoided by just keeping favourites the way they are here right now.

ClearlyClaire · 2018-04-17T12:06:56Z

@Gargron but why should that person be proud of something I haven't read yet? Afaik, people use favorites (or likes, that's what they are protocol-wise) as approval, encouragement, or “I read this” marks. A bookmark is “I want to read this” and is something completely different honestly.

Cassolotl · 2018-04-17T12:07:20Z

But I use favourites for that use case. And that having a social function makes sense to me, I remember the old Delicious used to display rankings of favourited links and stuff that authors of those links could be proud of.

I feel like basically there are two "save" features now - one that is viewable on posts and has people's names publicly attached, and one that isn't and doesn't.

This PR makes sense as a thing being tacked on, but as part of a bigger picture it is quite messy, I think?

So, how about making likes just a reaction? (I'm sure folks have seen me say this before, so I'm sorry if I'm repeating it for anyone here!) Likes could be not saved in a list for you to view later, and likes could be not included in search results. It's just a social signal way to say "awesome" or "thanks" or whatever. The numbers would still publicly be attached to toots for Delicious-style rankings etc.

I'm very much in favour of public like-reactions and private saves. They seem like two different functions to me.

Also we have bookmarks on dev.glitch.social right now and it is good. :D

ClearlyClaire · 2018-05-12T18:27:54Z

Worth a shot I guess 🤷‍♂️

ClearlyClaire · 2018-08-10T13:27:00Z

Updated the PR to:

Rebase it
Remove the joke rainbows
Add OAuth scopes for bookmarks

Bookmarks behave like favourites, except they aren't shared with other users and do not have an associated counter.

ClearlyClaire · 2019-11-12T22:33:14Z

Rebased and fixed the migration. Would have to go other it to make sure everything has been kept up-to-date.

umonaca · 2019-11-13T02:57:20Z

You would probably want this commit and this commit as well

umonaca · 2019-11-13T03:17:49Z

Bug report: the un-bookmark is not as responsive as the un-favourite. When a toot is unbookmarked, the icon remains active so the user is unsure if the toot has been unbookmarked or not. The user has to refresh the entire page to see the unbookmark has succeeded.

I reported this issue in glitch-soc but was unable to reproduce it on the glitch-soc instance. However, I am able to reliably reproduce this bug in this PR in a local test environment.

Gargron · 2019-11-13T21:55:43Z

        <div className='detailed-status__button'><IconButton disabled={reblog_disabled} active={status.get('reblogged')} title={reblog_disabled ? intl.formatMessage(messages.cannot_reblog) : intl.formatMessage(messages.reblog)} icon={reblogIcon} onClick={this.handleReblogClick} /></div>
        <div className='detailed-status__button'><IconButton className='star-icon' animate active={status.get('favourited')} title={intl.formatMessage(messages.favourite)} icon='star' onClick={this.handleFavouriteClick} /></div>
        {shareButton}
+        <div className='detailed-status__button'><IconButton className='bookmark-icon' active={status.get('bookmarked')} title={intl.formatMessage(messages.bookmark)} icon='bookmark' onClick={this.handleBookmarkClick} /></div>


I heard at least one user opinion that favourites and bookmarks not need be side-by-side, bookmarks can be in the dropdown menu. More responses have stated that they would use bookmarks more rarely than favourites, so perhaps this makes sense? Thoughts?

Oh well, we can move it later.

* Add backend support for bookmarks Bookmarks behave like favourites, except they aren't shared with other users and do not have an associated counter. * Add spec for bookmark endpoints * Add front-end support for bookmarks * Introduce OAuth scopes for bookmarks * Add bookmarks to archive takeout * Fix migration * Coding style fixes * Fix rebase issue * Update bookmarked_statuses to latest UI changes * Update bookmark actions to properly reflect status changes in state * Add bookmarks item to single-column layout * Make active bookmarks red Conflicts: app/javascript/mastodon/actions/interactions.js app/javascript/mastodon/components/status_action_bar.js app/javascript/mastodon/features/bookmarked_statuses/index.js db/migrate/20180831171112_create_bookmarks.rb

bannisdale · 2019-11-28T11:17:06Z

Maybe a stupid question, but ... is this already live? Is this part of the next release? How would I be able to find out? :)

Gargron · 2019-11-29T20:52:33Z

It's live on mastodon.social, but no stable version has been released since this PR was merged, yet.

ClearlyClaire added the enhancement label Apr 11, 2018

ClearlyClaire force-pushed the features/bookmarks branch 2 times, most recently from cf9ea7d to 7d66300 Compare April 11, 2018 19:06

Cassolotl mentioned this pull request Apr 11, 2018

Dream feature: "like" and "save" separately #1178

Closed

1 task

ClearlyClaire force-pushed the features/bookmarks branch from 7d66300 to c21ec21 Compare April 12, 2018 15:55

ClearlyClaire force-pushed the features/bookmarks branch 2 times, most recently from 9713111 to f2be5ca Compare April 16, 2018 21:02

ClearlyClaire force-pushed the features/bookmarks branch 2 times, most recently from 95bc1f9 to c92e37b Compare April 19, 2018 09:50

ClearlyClaire force-pushed the features/bookmarks branch from c92e37b to 649f397 Compare May 12, 2018 17:58

ClearlyClaire force-pushed the features/bookmarks branch 2 times, most recently from 077c07c to 249ee1f Compare May 14, 2018 19:18

ClearlyClaire force-pushed the features/bookmarks branch from 249ee1f to 3aae5fd Compare August 10, 2018 13:22

ClearlyClaire force-pushed the features/bookmarks branch from 3aae5fd to 6abaaab Compare August 31, 2018 15:14

Gargron added the suggestion label Oct 20, 2018

ClearlyClaire added 6 commits November 12, 2019 23:23

Add backend support for bookmarks

6ff8990

Bookmarks behave like favourites, except they aren't shared with other users and do not have an associated counter.

Add spec for bookmark endpoints

f038db0

Add front-end support for bookmarks

6b672b3

Introduce OAuth scopes for bookmarks

1d52aee

Add bookmarks to archive takeout

7364159

Fix migration

de30c73

ClearlyClaire force-pushed the features/bookmarks branch from c4a6990 to de30c73 Compare November 12, 2019 22:28

umonaca suggested changes Nov 13, 2019

View reviewed changes

Comment thread app/javascript/mastodon/features/getting_started/index.js Outdated

umonaca suggested changes Nov 13, 2019

View reviewed changes

Comment thread app/javascript/mastodon/actions/interactions.js

umonaca reviewed Nov 13, 2019

View reviewed changes

Comment thread app/javascript/mastodon/components/status_action_bar.js Outdated

ClearlyClaire added 5 commits November 13, 2019 13:37

Coding style fixes

94959f6

Fix rebase issue

fb60a59

Update bookmarked_statuses to latest UI changes

4cb51f1

Update bookmark actions to properly reflect status changes in state

005c3ba

Add bookmarks item to single-column layout

be06e13

ClearlyClaire force-pushed the features/bookmarks branch from e113436 to be06e13 Compare November 13, 2019 20:28

Make active bookmarks red

06d9489

ClearlyClaire force-pushed the features/bookmarks branch from 76dbf16 to 06d9489 Compare November 13, 2019 20:40

Gargron reviewed Nov 13, 2019

View reviewed changes

Gargron changed the title ~~Add a “bookmark” feature~~ Add bookmarks Nov 13, 2019

Gargron approved these changes Nov 13, 2019

View reviewed changes

Gargron merged commit dfea736 into mastodon:master Nov 13, 2019

Gargron mentioned this pull request Nov 13, 2019

Enhancement Idea: Bookmarks for Private Use #610

Closed

Gargron mentioned this pull request Dec 9, 2019

Option for Bookmarking/Saving Toots #12590

Closed

Uh oh!

Conversation

ClearlyClaire commented Apr 11, 2018

Uh oh!

Cassolotl commented Apr 11, 2018

Uh oh!

trwnh commented Apr 13, 2018

Uh oh!

Cassolotl commented Apr 13, 2018

Uh oh!

nightpool commented Apr 16, 2018

Uh oh!

nightpool commented Apr 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Cassolotl commented Apr 16, 2018

Uh oh!

Gargron commented Apr 16, 2018

Uh oh!

ClearlyClaire commented Apr 16, 2018

Uh oh!

lanodan commented Apr 16, 2018

Uh oh!

ClearlyClaire commented Apr 16, 2018

Uh oh!

Gargron commented Apr 17, 2018

Uh oh!

ClearlyClaire commented Apr 17, 2018

Uh oh!

Cassolotl commented Apr 17, 2018

Uh oh!

ClearlyClaire commented May 12, 2018

Uh oh!

ClearlyClaire commented Aug 10, 2018

Uh oh!

ClearlyClaire commented Nov 12, 2019

Uh oh!

Uh oh!

umonaca commented Nov 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

umonaca commented Nov 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gargron Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

Gargron Nov 13, 2019

Choose a reason for hiding this comment

Uh oh!

bannisdale commented Nov 28, 2019

Uh oh!

Gargron commented Nov 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

nightpool commented Apr 16, 2018 •

edited

Loading

umonaca commented Nov 13, 2019 •

edited

Loading

umonaca commented Nov 13, 2019 •

edited

Loading