Skip to content

feat: add policy folder#2960

Merged
PKief merged 8 commits intomaterial-extensions:mainfrom
SawyerNic:main
Apr 12, 2025
Merged

feat: add policy folder#2960
PKief merged 8 commits intomaterial-extensions:mainfrom
SawyerNic:main

Conversation

@SawyerNic
Copy link
Copy Markdown
Contributor

@SawyerNic SawyerNic commented Apr 7, 2025

Description

Created policy folder icons in response to issue #2722

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Apr 7, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

Copy link
Copy Markdown
Member

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your PR!

There are a few issues:

  • The icons must be squared (e.g. 32x32 pixels). This one is 30x~22. You can grab one of the already existant icons and use it as guide for positioning.

  • I think you're using an older folder shape (we changed the shapes of the folder icons a while ago). You can compare it to another folder icon to spot the differences.

  • The material design icon pack has a similar gavel icon. This extension, being a Material Design extension, should use that one instead (IMO): https://pictogrammers.com/library/mdi/icon/gavel/

Thanks!!

@SawyerNic SawyerNic changed the title Policy Folder Feat: Add policy folder Apr 7, 2025
@lucas-labs lucas-labs changed the title Feat: Add policy folder feat: add policy folder Apr 11, 2025
@lucas-labs
Copy link
Copy Markdown
Member

I changed the positions a bit, to align the shapes to the grid:

Copy link
Copy Markdown
Member

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PKief PKief merged commit a5415ac into material-extensions:main Apr 12, 2025
5 of 6 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons PR with new icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants