Ability to disable power/settings & customize title. Few bug fixes in layout and packaging. Adding source maps.#10
Open
ikogan wants to merge 1 commit intomatgallacher:masterfrom
Open
Conversation
- Change MANIFEST to pull in the specific static content we want. This avoid pulling in the unneeded source files. Also, originally, it wasn't pulling static in at all. Lastly, ignore the ".vs" directories. They should probably be added to .gitignore but I don't want to break upstream too much. - The mixer graphic was stretching to the height of the right content less the menu on the left for some reason. Give it a fixed height (in relative units) to avoid that. - Seeing "10.1.x.x" as the title wasn't terribly appealing, and, really the hostname may not be either. Add an option to force the title to something specific in the config file. - In some cases, the settings and power may not be relevant for all setups. Add config options to turn off the menu entries for them. - Since we need the settings in the main controller now, move the code that fetches them into a service and add a cache. - Enable sourcemaps in Uglify so debugging is significantly easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid pulling in the unneeded source files. Also, originally, it
wasn't pulling static in at all. Lastly, ignore the ".vs" directories.
They should probably be added to .gitignore but I don't want to break
upstream too much.
less the menu on the left for some reason. Give it a fixed height
(in relative units) to avoid that.
the hostname may not be either. Add an option to force the title
to something specific in the config file.
setups. Add config options to turn off the menu entries for them.
code that fetches them into a service and add a cache.