Fix various layout issues, add volume support, fix/finish implementation of playlist album art.#11
Open
ikogan wants to merge 5 commits intomatgallacher:masterfrom
Open
Fix various layout issues, add volume support, fix/finish implementation of playlist album art.#11ikogan wants to merge 5 commits intomatgallacher:masterfrom
ikogan wants to merge 5 commits intomatgallacher:masterfrom
Conversation
- Change MANIFEST to pull in the specific static content we want. This avoid pulling in the unneeded source files. Also, originally, it wasn't pulling static in at all. Lastly, ignore the ".vs" directories. They should probably be added to .gitignore but I don't want to break upstream too much. - The mixer graphic was stretching to the height of the right content less the menu on the left for some reason. Give it a fixed height (in relative units) to avoid that. - Seeing "10.1.x.x" as the title wasn't terribly appealing, and, really the hostname may not be either. Add an option to force the title to something specific in the config file. - In some cases, the settings and power may not be relevant for all setups. Add config options to turn off the menu entries for them. - Since we need the settings in the main controller now, move the code that fetches them into a service and add a cache. - Enable sourcemaps in Uglify so debugging is significantly easier.
- Change layout so that it's always displayed at the bottom regardless how long the current list is. - Change the way we choose whether or not to display it. As long as we have at least one item in the queue, display the toolbar. This allows us to control playback from anywhere in the app so long as something is in the queue.
…-pause-icon' into long-list-fixes Conflicts: mopidy_material_webclient/static/partials/queue.html
- Added support for controlling the volume. - Added ability to set the page title and the toolbar seperately. - Fixed some cases where the title would be set to undefined and throw errors. - Fixed album art in the playlist throwing errors and re-arranged the layout a bit to not overlap. - Added `lodash` for some functional niceties to make code more concise. - Redid the layout of the empty playlist text to be a bit cleaner. - Don't need to iterate by tlid. - Ensure we use https with audio scrobbler so that it actually works when the app is loaded with https. - Fix an issue with the `service.get()` being called twice while it's already loading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lodashfor some functional niceties to make code more concise.service.get()being called twice while it's already loading.