Only permit defined paths#77
Open
tumd wants to merge 1 commit intomatomo-org:masterfrom
Open
Conversation
This change denies everything by default, and only allows access to defined paths. It also makes it easy to restrict public access to the whole site (except matomo.js, matomo.php, piwik.js & piwik.php).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current nginx config is permissive by default which makes it unsafe and bad practice.
For example the file
console"php"-file is currently publicly accessible.And future new/renamed files or paths will be accessible too that hasn't been included in the nginx config.
This PR revers this and instead denies everything except for the the defined paths.
These changes also makes it easy to restrict public access the full matomo site, by still allowing access to the paths needed to gather analytics (matomo.js, matomo.php, piwik.js & piwik.php).
As this is a slightly modified variant of what I have been tested, it may need some proofing.