change log message for client errors

Author: sgiehl

core/API/Request.php

@@ -285,7 +285,7 @@ public function process()
             });
         } catch (Exception $e) {
             if ($e instanceof HttpCodeException && $e->getCode() >= 400 && $e->getCode() < 500) {
-                StaticContainer::get(LoggerInterface::class)->debug('Uncaught exception in API: {exception}', [
+                StaticContainer::get(LoggerInterface::class)->debug('Uncaught client error in API: {exception}', [
                     'exception'            => $e,
                     'ignoreInScreenWriter' => true,
                 ]);

core/Exception/ThingNotFoundException.php

@@ -15,6 +15,6 @@ class ThingNotFoundException extends \Piwik\Exception\Exception implements HttpC
 {
     public function __construct($message, $previous = null)
     {
-        parent::__construct($message, 400, $previous);
+        parent::__construct($message, 404, $previous);
     }
 }

core/FrontController.php

@@ -27,7 +27,6 @@
 use Piwik\Plugins\CoreAdminHome\CustomLogo;
 use Piwik\Session\SessionAuth;
 use Piwik\Session\SessionInitializer;
-use Piwik\SupportedBrowser;
 use Piwik\Log\LoggerInterface;
 
 /**
@@ -116,7 +115,7 @@ private static function generateSafeModeOutputFromError($lastError)
     public static function generateSafeModeOutputFromException($e)
     {
         if ($e instanceof HttpCodeException && $e->getCode() >= 400 && $e->getCode() < 500) {
-            StaticContainer::get(LoggerInterface::class)->debug('Uncaught exception: {exception}', [
+            StaticContainer::get(LoggerInterface::class)->debug('Uncaught client error: {exception}', [
                 'exception'            => $e,
                 'ignoreInScreenWriter' => true,
             ]);

tests/PHPUnit/Integration/AssetManager/UIAssetFetcher/PluginUmdAssetFetcherTest.php

@@ -12,8 +12,8 @@
 use Piwik\AssetManager\UIAsset\OnDiskUIAsset;
 use Piwik\AssetManager\UIAssetFetcher\Chunk;
 use Piwik\AssetManager\UIAssetFetcher\PluginUmdAssetFetcher;
+use Piwik\Exception\ThingNotFoundException;
 use Piwik\Filesystem;
-use Piwik\Http\BadRequestException;
 use Piwik\Plugin\Manager;
 use Piwik\Tests\Framework\TestCase\UnitTestCase;
 
@@ -178,7 +178,7 @@ public function testGetChunkFilesThrows404WhenChunkIsMissing()
         $plugins = array_keys(self::TEST_PLUGIN_DEPENDENCIES);
         $instance = new PluginUmdAssetFetcher($plugins, null, 'does-not-exist', false);
 
-        $this->expectException(BadRequestException::class);
+        $this->expectException(ThingNotFoundException::class);
         $this->expectExceptionCode(404);
 
         $instance->getCatalog();