Skip to content

Show all x axis labels for bar charts#19593

Draft
sgiehl wants to merge 1 commit into5.x-devfrom
m19592
Draft

Show all x axis labels for bar charts#19593
sgiehl wants to merge 1 commit into5.x-devfrom
m19592

Conversation

@sgiehl
Copy link
Copy Markdown
Member

@sgiehl sgiehl commented Aug 3, 2022

Description:

fixes #19592, fixes #8440

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 3, 2022
@sgiehl
Copy link
Copy Markdown
Member Author

sgiehl commented Aug 3, 2022

Note: Showing all labels can more easily cause overlapping labels if they are too long., like that is the case in out UI tests. Might be possible to fix this by making the labels multiline maybe:

@Starker3
Copy link
Copy Markdown
Contributor

Starker3 commented Aug 4, 2022

Could it maybe be a simple solution to just offset every 2nd label in the same way that we currently have every 2nd label hidden?
I.e. offset the label by one line height for every 2nd one.

@sgiehl
Copy link
Copy Markdown
Member Author

sgiehl commented Aug 4, 2022

@Starker3 might be a solution. But guess this looks ugly, when there actually would be enough space to display it on the same line.

@github-actions

This comment was marked as outdated.

@github-actions github-actions Bot added the Stale The label used by the Close Stale Issues action label Aug 19, 2022
@github-actions

This comment was marked as outdated.

@github-actions github-actions Bot added the Stale for long The label used by the Close Stale Issues action label Oct 1, 2022
@github-actions github-actions Bot removed Stale The label used by the Close Stale Issues action Stale for long The label used by the Close Stale Issues action labels Feb 12, 2025
@github-actions

This comment was marked as outdated.

@github-actions github-actions Bot added the Stale The label used by the Close Stale Issues action label Feb 28, 2025
@github-actions

This comment was marked as outdated.

@github-actions github-actions Bot added Stale for long The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action Stale for long The label used by the Close Stale Issues action labels Apr 11, 2025
@sgiehl sgiehl changed the base branch from 4.x-dev to 5.x-dev April 23, 2025 09:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2025

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions Bot added the Stale for long The label used by the Close Stale Issues action label Jun 5, 2025
@github-actions
Copy link
Copy Markdown
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions Bot added Stale The label used by the Close Stale Issues action and removed Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action labels Jun 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 2, 2025

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions Bot added the Stale for long The label used by the Close Stale Issues action label Aug 2, 2025
@github-actions
Copy link
Copy Markdown
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions Bot added Stale The label used by the Close Stale Issues action and removed Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action labels Aug 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions Bot added the Stale The label used by the Close Stale Issues action label Sep 20, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2025

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions Bot added the Stale for long The label used by the Close Stale Issues action label Nov 1, 2025
@github-actions github-actions Bot removed Stale The label used by the Close Stale Issues action Stale for long The label used by the Close Stale Issues action labels Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Development

Successfully merging this pull request may close these issues.

Missing labels on bar chart Bar Graph widget doesn't show all labels

2 participants