Skip to content

Automatically update idvisitor column across log tables on change#23249

Open
sgiehl wants to merge 8 commits into5.x-devfrom
dev-18901
Open

Automatically update idvisitor column across log tables on change#23249
sgiehl wants to merge 8 commits into5.x-devfrom
dev-18901

Conversation

@sgiehl
Copy link
Copy Markdown
Member

@sgiehl sgiehl commented Apr 24, 2025

Description:

There are a couple of cases where the visitor id might change during a visits. Most common ones are:

  • setting a userid during a visit
  • set cookie consent during a visit

Currently the visitorid is only updated in the log_visit table. Not updating the visitorid in other tables currently causes slightly inaccurate metrics for unique visitors in some reports.

This PR aims to introduce an automated update of all tables, that define a proper LogTable class.

fixes #22587

Review

@sgiehl sgiehl added this to the 5.4.0 milestone Apr 24, 2025
@sgiehl sgiehl changed the base branch from 5.x-dev to dev-18901-tests April 25, 2025 11:11
@sgiehl sgiehl marked this pull request as ready for review April 25, 2025 11:15
@sgiehl sgiehl requested a review from a team April 25, 2025 11:15
@michalkleiner michalkleiner self-assigned this Apr 29, 2025
Comment thread core/Tracker/LogTable.php
Comment thread core/Tracker/Model.php
Comment thread core/Tracker/Visit.php
Comment thread tests/PHPUnit/Integration/Tracker/UserIdVisitorIdTest.php
@michalkleiner michalkleiner removed their assignment Apr 29, 2025
Base automatically changed from dev-18901-tests to 5.x-dev May 9, 2025 15:14
@github-actions
Copy link
Copy Markdown
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions Bot added the Stale The label used by the Close Stale Issues action label May 24, 2025
@github-actions github-actions Bot removed the Stale The label used by the Close Stale Issues action label Jun 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 2, 2025

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions Bot added the Stale The label used by the Close Stale Issues action label Jul 2, 2025
@mneudert mneudert added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 2, 2025
@sgiehl sgiehl modified the milestones: 5.4.0, 5.5.0 Aug 20, 2025
@sgiehl sgiehl modified the milestones: 5.5.0, 5.6.0 Oct 1, 2025
@sgiehl sgiehl modified the milestones: 5.6.0, 5.7.0 Nov 21, 2025
@sgiehl sgiehl force-pushed the dev-18901 branch 3 times, most recently from d5fc18f to 9ce7287 Compare December 12, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not close PRs with this label won't be marked as stale by the Close Stale Issues action

Development

Successfully merging this pull request may close these issues.

[Bug] For same idvisit, idvisitor is different in different tables.

4 participants