Conversation
mneudert
force-pushed
the
improve-rollup
branch
3 times, most recently
from
315a982 to
5a73c96
Compare
mneudert
added
Bug
sgiehl
force-pushed
the
improve-rollup
branch
from
2e1da6a to
1376a0c
Compare
sgiehl
requested changes
Dec 5, 2025
sgiehl
approved these changes
Dec 8, 2025
nathangavin
pushed a commit
that referenced
this pull request
Dec 10, 2025
* Improve "Others" aggregation for rollup ranking queries * Always sort rollup results to ensure ordering * Remove no longer needed double rollup result iteration * Add test to ensure rollup ranking query result structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rollup Ranking queries have an issue in generating the correct rollup rows for the first dimension, e.g. a rollup for the labels
custom_dimensionandurlmight not receive the expectedurl == __mtm_ranking_query_others__results upon exceeding the ranking limits.At the same time the result order was not completely fixed across database vendors/versions. This meant a double iteration was required to safely build the report tables.
This PR attempts to fix both issues by modifying the rollup queries. Non-rollup queries should not be affected.
Requirement for #23863.
Checklist
Review