Skip to content

fix invalid test by making provider method public#23890

Merged
caddoo merged 1 commit into5.x-devfrom
fix-invalid-test
Dec 10, 2025
Merged

fix invalid test by making provider method public#23890
caddoo merged 1 commit into5.x-devfrom
fix-invalid-test

Conversation

@nathangavin
Copy link
Copy Markdown
Contributor

@nathangavin nathangavin commented Dec 10, 2025 •
edited
Loading

Description

Fixes issue raised by Stefan regarding invalid test Piwik\Tests\Integration\Tracker\VisitTest::testVisitMajorVersionPolicyControlled, due to a private data provider method.

Checklist

  • [NA] I have understood, reviewed, and tested all AI outputs before use
  • [NA] All AI instructions respect security, IP, and privacy rules

Review

@nathangavin nathangavin requested a review from a team December 10, 2025 20:23
@caddoo caddoo merged commit 15b9570 into 5.x-dev Dec 10, 2025
28 of 31 checks passed
@caddoo caddoo deleted the fix-invalid-test branch December 10, 2025 21:12
@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. and removed Needs Review labels Dec 10, 2025
@sgiehl sgiehl added this to the 5.7.0 milestone Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caddoo caddoo caddoo approved these changes

Assignees

No one assigned

Labels

c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.

Milestone

5.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nathangavin @caddoo @sgiehl
⚡