Make SegmentSelectorEditor tests less flaky#24138
Merged
Conversation
chippison
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These screenshot tests were flaky for me (each failed at least once), likely due to hover/tooltips being captured.
This PR moves the mouse out of the capture area before taking the affected screenshots to stabilize them.
It also improves debugging clarity by splitting a shared baseline: two tests previously used updated.png, which made
failures harder to interpret (often showing no useful diff). The reload-step test now uses its own duplicated baseline
image so each assertion can fail independently with clearer output.
Failures addressed:
https://builds-artifacts.matomo.org/matomo-org/matomo/preview_alerts/22417472720/
https://builds-artifacts.matomo.org/matomo-org/matomo/segment_selector_editor_flaky/22423974975/
Checklist
Review