Skip to content

Improve permission check in Live.getFirstVisitForVisitorId#24146

Merged
chippison merged 1 commit into5.x-devfrom
permcheck
Mar 1, 2026
Merged

Improve permission check in Live.getFirstVisitForVisitorId#24146
chippison merged 1 commit into5.x-devfrom
permcheck

Conversation

@sgiehl
Copy link
Copy Markdown
Member

@sgiehl sgiehl commented Feb 27, 2026

Description

The view permission for the specific site was already implicitly checked through Live::checkIsVisitorProfileEnabled($idSite).
Doing that directly avoids confusion on really required permissions.

Checklist

  • [NA] I have understood, reviewed, and tested all AI outputs before use
  • [NA] All AI instructions respect security, IP, and privacy rules

Review

@sgiehl sgiehl added this to the 5.9.0 milestone Feb 27, 2026
@sgiehl sgiehl requested a review from a team February 27, 2026 15:08
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Technical debt Issues the will help to reduce technical debt labels Feb 27, 2026
@chippison chippison merged commit f618964 into 5.x-dev Mar 1, 2026
50 of 52 checks passed
@chippison chippison deleted the permcheck branch March 1, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Technical debt Issues the will help to reduce technical debt

Development

Successfully merging this pull request may close these issues.

2 participants