Skip to content

Improve vue:build with a retry detection on missing path#24149

Merged
sgiehl merged 2 commits into5.x-devfrom
more-stable-vue-build
Mar 2, 2026
Merged

Improve vue:build with a retry detection on missing path#24149
sgiehl merged 2 commits into5.x-devfrom
more-stable-vue-build

Conversation

@tzi
Copy link
Copy Markdown
Contributor

@tzi tzi commented Feb 28, 2026

Description

vue:build is a bit flaky in CI and it's always the same error:

   error  in /home/runner/work/matomo/matomo/plugins/Installation/vue/src/SystemCheck/SystemCheck.vue.ts

  [tsl] ERROR in /home/runner/work/matomo/matomo/plugins/Installation/vue/src/SystemCheck/SystemCheck.vue(48,31)
        TS2307: Cannot find module './SystemCheckLegend.vue' or its corresponding type declarations.

   error  in /home/runner/work/matomo/matomo/plugins/Installation/vue/src/SystemCheck/SystemCheckSection.vue.ts

  [tsl] ERROR in /home/runner/work/matomo/matomo/plugins/Installation/vue/src/SystemCheck/SystemCheckSection.vue(86,29)
        TS2307: Cannot find module './DiagnosticTable.vue' or its corresponding type declarations.

This is certainly a compiler race/flakiness.

We can fixed it with a retry detection in Build.php:

  • Before, Matomo only detected TS2307 race for very limited patterns.
  • It missed relative-import TS2307 cases like your Installation ones.
  • Now it parses TS2307 with importer file context and correctly treats existing relative targets as transient, so vue:build retries automatically instead of failing CI immediately.

Checklist

  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules

Review

@tzi tzi added this to the 5.9.0 milestone Feb 28, 2026
Comment thread plugins/CoreHome/vue/src/Alert/Alert.vue Outdated
@tzi
Copy link
Copy Markdown
Contributor Author

tzi commented Feb 28, 2026

✅ Tested 5 times without any error

@tzi tzi force-pushed the more-stable-vue-build branch from da39d65 to a0a9e28 Compare February 28, 2026 22:01
@tzi tzi added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. labels Mar 2, 2026
Copy link
Copy Markdown
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it would improve things. Let's see if things get better that way.

@sgiehl sgiehl merged commit c582e0e into 5.x-dev Mar 2, 2026
101 of 106 checks passed
@sgiehl sgiehl deleted the more-stable-vue-build branch March 2, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Development

Successfully merging this pull request may close these issues.

2 participants