Skip to content

UI tests - UserManager - fix flaky test#24156

Merged
sgiehl merged 2 commits into5.x-devfrom
improve-user-permission-tests
Mar 2, 2026
Merged

UI tests - UserManager - fix flaky test#24156
sgiehl merged 2 commits into5.x-devfrom
improve-user-permission-tests

Conversation

@tzi
Copy link
Copy Markdown
Contributor

@tzi tzi commented Mar 2, 2026

Description

Several tests from the User Permission UI Tests are flaky, because of page scroll.
I try to solve it by only screenshot the user permission form and avoid difference from scroll state.

Examples

From a failing CI:

UsersManager_permissions_bulk_access_set_all.png

Processed Expected 
image image

Checklist

  • [NA] I have understood, reviewed, and tested all AI outputs before use
  • [NA] All AI instructions respect security, IP, and privacy rules

Review

@tzi tzi added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 2, 2026
@tzi tzi added this to the 5.9.0 milestone Mar 2, 2026
@tzi tzi added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Mar 2, 2026
@tzi tzi force-pushed the improve-user-permission-tests branch from 0c8f937 to d0b22db Compare March 2, 2026 11:05
@tzi tzi changed the title UI tests - UserManager - smaller screenshots more stability UI tests - UserManager - fix flaky test Mar 2, 2026
@tzi tzi force-pushed the improve-user-permission-tests branch from f4bff87 to 3475cab Compare March 2, 2026 13:38
@sgiehl sgiehl enabled auto-merge (squash) March 2, 2026 13:43
@sgiehl sgiehl merged commit 82c6550 into 5.x-dev Mar 2, 2026
30 checks passed
@sgiehl sgiehl deleted the improve-user-permission-tests branch March 2, 2026 14:13
@sgiehl
Copy link
Copy Markdown
Member

sgiehl commented Mar 3, 2026

@tzi
Copy link
Copy Markdown
Contributor Author

tzi commented Mar 3, 2026

So sad. 😞
It doesn't make sense to me to have a scroll problem on this kind of screenshot…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Development

Successfully merging this pull request may close these issues.

2 participants