Skip to content

CoreUpdater: prevent token creation/disclosure via oneClickResults#24240

Merged
sgiehl merged 3 commits into5.x-devfrom
dev-19893
Apr 27, 2026
Merged

CoreUpdater: prevent token creation/disclosure via oneClickResults#24240
sgiehl merged 3 commits into5.x-devfrom
dev-19893

Conversation

@sgiehl
Copy link
Copy Markdown
Member

@sgiehl sgiehl commented Mar 17, 2026

Summary

This PR refines the CoreUpdater one-click update flow by centralizing update_details_token lifecycle handling in oneClickUpdate()
and keeping oneClickResults() focused on rendering.

What changed

  • In plugins/CoreUpdater/Controller.php:
  • oneClickUpdate() now rotates update_details_token at update start.
  • oneClickResults() now reads existing token state and does not persist token changes.
  • oneClickResults() includes updateDetailsToken in runUpdaterUrl only in superuser context.
  • Added helper methods for explicit token refresh/read behavior:
  • refreshUpdateDetailsToken()
  • getUpdateDetailsToken()

Behavior impact

  • Token management is now aligned with update initiation.
  • Result page rendering remains intact and continues to provide a valid continuation URL when applicable.
  • Existing token cleanup behavior after update completion remains unchanged.

fixes #24196

Checklist

  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules

Review

@sgiehl sgiehl added this to the 5.9.0 milestone Mar 17, 2026
Comment thread plugins/CoreUpdater/tests/Integration/ControllerTest.php
@sgiehl sgiehl force-pushed the dev-19893 branch 4 times, most recently from 5748421 to 9482456 Compare March 19, 2026 14:25
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions Bot added the Stale The label used by the Close Stale Issues action label Apr 3, 2026
@sgiehl sgiehl modified the milestones: 5.9.0, 5.10.0 Apr 13, 2026
@github-actions github-actions Bot removed the Stale The label used by the Close Stale Issues action label Apr 14, 2026
@sgiehl sgiehl force-pushed the dev-19893 branch 2 times, most recently from 917a623 to 1633d26 Compare April 20, 2026 14:40
@sgiehl sgiehl force-pushed the dev-19893 branch 3 times, most recently from 18bb496 to 1aa5498 Compare April 22, 2026 13:08
@sgiehl sgiehl requested a review from a team April 22, 2026 13:08
@sgiehl sgiehl marked this pull request as ready for review April 22, 2026 13:09
chippison
chippison previously approved these changes Apr 22, 2026
@sgiehl sgiehl enabled auto-merge (squash) April 27, 2026 16:42
@sgiehl sgiehl merged commit f486f33 into 5.x-dev Apr 27, 2026
30 checks passed
@sgiehl sgiehl deleted the dev-19893 branch April 27, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect query param documented in runUpdaterAndExit_welcome.twig

3 participants